Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/bottom sheet open twice #159

Merged
merged 2 commits into from
Feb 7, 2024
Merged

Fix/bottom sheet open twice #159

merged 2 commits into from
Feb 7, 2024

Conversation

Jinho1011
Copy link
Member

What is this PR? ๐Ÿ”

  • ๋ฐ”ํ…€์‹œํŠธ๋ฅผ ์ฒ˜์Œ ์‹คํ–‰ํ•  ๋•Œ ๋‘ ๋ฒˆ ์—ด๋ฆฌ๋Š” ๋ฌธ์ œ
  • ๊ธฐ๋ณธ ํ”„๋กœํ•„ ์ด๋ฏธ์ง€ ์ถ”๊ฐ€(ProfileImg)

๐Ÿ› ๏ธ Issue

Changes ๐Ÿ“

return { BottomSheet: isOpen ? Sheet : () => null, toggleSheet };

๊ธฐ์กด์— useBottomSheet์—์„œ ์œ„์™€ ๊ฐ™์ด ๋ฐ”ํ…€์‹œํŠธ๋ฅผ ๋ถˆ๋Ÿฌ์˜ค๊ณ  ์žˆ์—ˆ๋Š”๋ฐ ์ด๋ ‡๊ฒŒ ํ•˜๋ฉด BottomSheet ๋‚ด๋ถ€์˜ ๋ผ์ดํ”„์‚ฌ์ดํด์— ๋ฌธ์ œ๊ฐ€ ์ƒ๊ฒจ ๋‘ ๋ฒˆ ๋„์›Œ์ง„๊ฑฐ ๊ฐ™์Œ

To Reviewers ๐Ÿ“ข

  • ์ด ๋ถ€๋ถ„ ์ข€ ๊ฐ™์ด ๋ด์ฃผ์„ธ์š” / ํ˜น์€ ํ•˜๊ณ  ์‹ถ์€ ๋ง

@netlify Netlify
Copy link

netlify bot commented Feb 4, 2024 •
edited
Loading

โœ… Deploy Preview for offonoff-ab ready!

Name Link
๐Ÿ”จ Latest commit 3c153bb
๐Ÿ” Latest deploy log https://app.netlify.com/sites/offonoff-ab/deploys/65bf1396d350960008454464
๐Ÿ˜Ž Deploy Preview https://deploy-preview-159--offonoff-ab.netlify.app/
๐Ÿ“ฑ Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Jinho1011 Jinho1011 merged commit 9ccb3eb into dev Feb 7, 2024
5 checks passed
@Jinho1011 Jinho1011 deleted the fix/bottom-sheet-open-twice branch February 7, 2024 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

๋ฐ”ํ…€์‹œํŠธ๊ฐ€ ๋‘๋ฒˆ ์˜ฌ๋ผ์˜ค๋Š” ํ˜„์ƒ
1 participant
@Jinho1011